HyukjinKwon commented on a change in pull request #27728:
URL: https://github.com/apache/spark/pull/27728#discussion_r411030204
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -652,10 +652,19 @@ object DataSourceStrategy {
*/
object PushableColumn {
def unapply(e: Expression): Option[String] = {
- def helper(e: Expression) = e match {
- case a: Attribute => Some(a.name)
+ val nestedPredicatePushdownEnabled =
SQLConf.get.nestedPredicatePushdownEnabled
+ import
org.apache.spark.sql.connector.catalog.CatalogV2Implicits.MultipartIdentifierHelper
+ def helper(e: Expression): Option[Seq[String]] = e match {
+ case a: Attribute =>
+ if (nestedPredicatePushdownEnabled || !a.name.contains(".")) {
+ Some(Seq(a.name))
+ } else {
+ None
+ }
+ case s: GetStructField if nestedPredicatePushdownEnabled =>
+ helper(s.child).map(_ :+ s.childSchema(s.ordinal).name)
case _ => None
}
- helper(e)
+ helper(e).map(_.quoted)
Review comment:
Yes, this was pointed out and discussed at
https://github.com/apache/spark/pull/27728#discussion_r397742247 and
https://github.com/apache/spark/pull/27728#discussion_r397745115.
@HeartSaVioR is working on it against this JIRA SPARK-31365. I turned the
JIRA to be a blocker for Spark 3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
