HyukjinKwon commented on a change in pull request #28085: URL: https://github.com/apache/spark/pull/28085#discussion_r411033579
########## File path: python/pyspark/resource/resourceprofile.py ########## @@ -0,0 +1,72 @@ + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +from pyspark.resource.taskrequests import TaskResourceRequest +from pyspark.resource.executorrequests import ExecutorResourceRequest + + +class ResourceProfile(object): + + """ + .. note:: Evolving + + Resource profile to associate with an RDD. A :class:`pyspark.resource.ResourceProfile` + allows the user to specify executor and task requirements for an RDD that will get + applied during a stage. This allows the user to change the resource requirements between + stages. This is meant to be immutable so user doesn't change it after building. + + .. versionadded:: 3.1.0 + """ + + def __init__(self, _java_resource_profile=None, _exec_req={}, _task_req={}): + if _java_resource_profile is not None: + self._java_resource_profile = _java_resource_profile + else: + self._java_resource_profile = None + self._executor_resource_requests = _exec_req + self._task_resource_requests = _task_req + + @property + def id(self): + if self._java_resource_profile is not None: + return self._java_resource_profile.id() + else: + raise RuntimeError("SparkContext must be created to get the id, get the id " + "after adding the ResourceProfile to an RDD") Review comment: +1, thanks for addressing my comment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
