cloud-fan commented on a change in pull request #28261:
URL: https://github.com/apache/spark/pull/28261#discussion_r411152114
##########
File path:
sql/core/v2.3/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala
##########
@@ -451,5 +452,31 @@ class OrcFilterSuite extends OrcTest with
SharedSparkSession {
).get.toString
}
}
+
+ test("filter pushdown - local date") {
+ val dates = Seq("2017-08-18", "2017-08-19", "2017-08-20",
"2017-08-21").map { day =>
+ LocalDate.parse(day)
+ }
+ withSQLConf(SQLConf.DATETIME_JAVA8API_ENABLED.key -> "true") {
Review comment:
It makes me realize that this config can break data source v1/v2 as it
changes the value in `Filter`.
Shall we fix `DataSourceAnalysis.translateLeafNodeFilter` instead to always
return java 7 Date/Timestamp?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
