cloud-fan commented on a change in pull request #28272:
URL: https://github.com/apache/spark/pull/28272#discussion_r411306125



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -448,47 +448,54 @@ object DataSourceStrategy {
     }
   }
 
+  private def translateFilterValues(catalystValue: Any, dataType: DataType): 
Any = {
+    dataType match {
+      case DateType => DateConverter.toScala(catalystValue)

Review comment:
       what if the predicate is `col = array(date_value)`? Seems better to add 
a new boolean flag in `createToScalaConverter`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to