dongjoon-hyun commented on a change in pull request #28272:
URL: https://github.com/apache/spark/pull/28272#discussion_r411529369
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
##########
@@ -470,7 +478,10 @@ object CatalystTypeConverters {
* This method is slow, and for batch conversion you should be using
converter
* produced by createToScalaConverter.
*/
- def convertToScala(catalystValue: Any, dataType: DataType): Any = {
- createToScalaConverter(dataType)(catalystValue)
+ def convertToScala(
+ catalystValue: Any,
+ dataType: DataType,
+ useJava8DateTimeApi: Boolean = SQLConf.get.datetimeJava8ApiEnabled): Any
= {
Review comment:
In the master branch code, the only occurrence using this default value
seems to be `toJson(CatalystTypeConverters.convertToScala(udt.serialize(v),
dataType), dataType)`. Shall we remove this default value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
