HyukjinKwon commented on a change in pull request #26965:
URL: https://github.com/apache/spark/pull/26965#discussion_r411809931



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
##########
@@ -101,8 +101,9 @@ private[this] object JsonPathParser extends RegexParsers {
 
 private[this] object SharedFactory {
   val jsonFactory = new JsonFactoryBuilder()
-    // Enabled for Hive compatibility
+    // The two options below enabled for Hive compatibility
     .enable(JsonReadFeature.ALLOW_UNESCAPED_CONTROL_CHARS)
+    .enable(JsonReadFeature.ALLOW_SINGLE_QUOTES)

Review comment:
       It's too corner case to document .. who will rely on the behaviour of 
`null` from a single quote JSON ... Users from Hive might depend on the single 
quote behaviours but It's pretty unlikely for Spark users to depend on single 
quoted JSONs.
   
   What about we think about fixing it when it's actually requested from users?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to