xwu99 commented on issue #28229: URL: https://github.com/apache/spark/pull/28229#issuecomment-616953665
@zhengruifeng I am OK with inline switch instead of SparkConf. My general points: 1) Matrix-multiply is highly optimized routine by the industry. If take advantage of it, we can leverage hardware vendors' low-level optimization when available 2) Sparse matrix also has [native optimization](https://software.intel.com/en-us/mkl-developer-reference-c-mkl-sparse-spmm), but it's not part of standard BLAS and current BLAS in Spark doesn't support the optimized one of it. 3) I do believe the parameters requires tuning (such as K, rowsPerMatrix) and we can do more benchmarks and give guidelines to end users on how to set them to get best performance. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
