HyukjinKwon commented on a change in pull request #28267:
URL: https://github.com/apache/spark/pull/28267#discussion_r411873134
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/LocalityPreferredContainerPlacementStrategy.scala
##########
@@ -63,16 +63,16 @@ private[yarn] case class
ContainerLocalityPreferences(nodes: Array[String], rack
* follow the method of 1 and 2.
*
* 4. If containers exist and some of them can match the requested localities.
- * For example if we have 1 containers on each node (host1: 1, host2: 1:
host3: 1, host4: 1),
+ * For example if we have 1 container on each node (host1: 1, host2: 1: host3:
1, host4: 1),
* and the expected containers on each node would be (host1: 5, host2: 5,
host3: 4, host4: 2),
* so the newly requested containers on each node would be updated to (host1:
4, host2: 4,
* host3: 3, host4: 1), 12 containers by total.
*
* 4.1 If requested container number (18) is more than newly required
containers (12). Follow
- * method 1 with updated ratio 4 : 4 : 3 : 1.
+ * method 1 with an updated ratio 4 : 4 : 3 : 1.
Review comment:
I think this `an ` can be removed too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
