Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4885#discussion_r26369119
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -272,6 +244,44 @@ class HiveContext(sc: SparkContext) extends
SQLContext(sc) {
Nil
}
+ override protected[sql] def createSession(): SQLSession = {
+ new this.SQLSession()
+ }
+
+ protected[hive] class SQLSession extends super.SQLSession {
--- End diff --
@guowei2 I think either way is OK for now. Putting all session-specific
stuff into a central place (`SQLSession`) seems cleaner to me. Making
`SQLSession` a thread-local does look a little ugly, however, right now it's
not used anywhere other than the Thrift server. When we do decide to move Hive
into a separate data source and make our own data source neutral Spark SQL
server, we can handle the session problem in a cleaner way (e.g., using an
actor for each session and keep all session-specific stuff in the actor
instance).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
