cloud-fan commented on a change in pull request #28272:
URL: https://github.com/apache/spark/pull/28272#discussion_r412001370
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -450,45 +450,45 @@ object DataSourceStrategy {
private def translateLeafNodeFilter(predicate: Expression): Option[Filter] =
predicate match {
case expressions.EqualTo(PushableColumn(name), Literal(v, t)) =>
- Some(sources.EqualTo(name, convertToScala(v, t)))
+ Some(sources.EqualTo(name, convertToScala(v, t, false)))
Review comment:
I think it's problematic to let the java8 config also control the value
type inside `Filter`, as it can break existing DS v1 implementations. It's a
bit unfortunate that we don't document clearly what the value type can be for
`Filter`, but if we do, it's not user-friendly to say "the value type depends
on xxx config". This just makes it harder to implement data source filter
pushdown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
