cloud-fan commented on issue #28026: URL: https://github.com/apache/spark/pull/28026#issuecomment-617210890
I agree with your solution about OPTIONS vs TBLPROPERTIES. As an end-user, I'd expect to see `TBLPROPERTIES` as the only way to specify configs, to make the story simple. But the `OPTIONS` is already there for a long time and it's better to not drop it. I'm still not convinced about the `EXTERNAL` part. It's also there for a long time, but it only takes effect in the parser. I don't treat it as a SQL feature, but just an auxiliary keyword in the parser. You are right that it's different in Hive as Hive allows EXTERNAL with LOCATION and without it, but we are talking about the catalog plugin of Spark. We can expose `EXTERNAL` to the catalog plugin, so that Spark can be more compatible with Hive QL. But I don't think that's a goal and it looks not necessary to me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
