HyukjinKwon commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r412893096
##########
File path: sql/gen-sql-config-docs.py
##########
@@ -114,11 +119,17 @@ def generate_sql_configs_table_html(sql_configs, path):
if __name__ == "__main__":
+ if len(sys.argv) != 2:
+ print("Usage: ./bin/spark-submit sql/gen-sql-config-docs.py
<static|runtime>")
Review comment:
You could just call the function twice instead of adding an argument
considering that SQL configuration gen is pretty cheap. Let's fix it next time
when we happen to touch here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
