srowen commented on a change in pull request #28291:
URL: https://github.com/apache/spark/pull/28291#discussion_r413051339
##########
File path: mllib/src/main/scala/org/apache/spark/ml/util/SchemaUtils.scala
##########
@@ -40,6 +40,8 @@ private[spark] object SchemaUtils {
msg: String = ""): Unit = {
val actualDataType = schema(colName).dataType
val message = if (msg != null && msg.trim.length > 0) " " + msg else ""
+
require(actualDataType.getClass.getPackage.equals(dataType.getClass.getPackage),
+ s"Column $colName of type ${dataType.typeName} must belong to ml
package")
Review comment:
I think you just want to improve the existing message; add the types
that were checked. It doesn't need to be separate and that specific.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
