maropu commented on a change in pull request #28290:
URL: https://github.com/apache/spark/pull/28290#discussion_r413404492



##########
File path: docs/sql-getting-started.md
##########
@@ -347,7 +347,8 @@ For example:
 </div>
 
 ## Scalar Functions
-(to be filled soon)
+
+Scalar functions are functions that return a single value per row, as opposed 
to aggregation functions, which return a value for a group of rows. Spark SQL 
supports a variety of built-in scalar functions such as [Array 
Functions](sql-ref-functions-builtin.html#array-functions), [Map 
Functions](sql-ref-functions-builtin.html#map-functions), [Date and Timestamp 
Functions](sql-ref-functions-builtin.html#date-and-timestamp-functions), etc. 
It also supports [User Defined Scalar 
Functions](sql-ref-functions-udf-scalar.html).

Review comment:
       Probably, we need to organize both paragraphs more. For example, how 
about this?
   
   Adds two categories for built-in functions in 
`sql-ref-functions.html#built-in-functions`;
   ```
   ### Built-in Functions
   Spark SQL has some ...
    
   ####  Scalar Functions 
   Array Functions
   Map Functions
   Date and Timestamp Functions
   JSON Functions
   
   #### Aggregate-like Functions
   Aggregate Functions
   Window Functions
   ```
   
   Then,
   ```
   ## Scalar Functions
   A short description about scalar built-in functions and UDFs, then we add 
two links to their scalar sections.
   
   ## Aggregate Functions
   A short description about aggregate built-in functions and UDFs, then we add 
two links to their aggregate sections.
   ```
   Anyway, I think both categories had better to have same granularity 
description.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to