ulysses-you commented on a change in pull request #28304:
URL: https://github.com/apache/spark/pull/28304#discussion_r413470723
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
##########
@@ -40,6 +40,13 @@ abstract class LogicalPlan
super.verboseString(maxFields) + statsCache.map(", " +
_.toString).getOrElse("")
}
+ override protected def doCanonicalize(): LogicalPlan = {
+ if (!resolved) {
Review comment:
Considered use assert, but it can be happen in a special way. e.g.
```
spark.sql("select id, count(*) from t1 group by id limit
1").queryExecution.logical.canonicalized
```
So throwing maybe better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
