maropu commented on a change in pull request #28290:
URL: https://github.com/apache/spark/pull/28290#discussion_r413589297
##########
File path: docs/sql-ref-functions.md
##########
@@ -27,12 +27,15 @@ Built-in functions are commonly used routines that Spark
SQL predefines and a co
Spark SQL has some categories of frequently-used built-in functions for
aggregtion, arrays/maps, date/timestamp, and JSON data.
This subsection presents the usages and descriptions of these functions.
- * [Aggregate Functions](sql-ref-functions-builtin.html#aggregate-functions)
- * [Window Functions](sql-ref-functions-builtin.html#window-functions)
+#### Scalar Functions
* [Array Functions](sql-ref-functions-builtin.html#array-functions)
* [Map Functions](sql-ref-functions-builtin.html#map-functions)
* [Date and Timestamp
Functions](sql-ref-functions-builtin.html#date-and-timestamp-functions)
* [JSON Functions](sql-ref-functions-builtin.html#json-functions)
+ * [Window Functions](sql-ref-functions-builtin.html#window-functions)
Review comment:
> OK... Seems Window functions still should be put in the Scalar
function category. I will double check tomorrow.
Why do you think so? Putting this in the scalar category still looks weird
to me.
The other parts look ok. Also, could you file a jira, just in case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
