marblejenka commented on a change in pull request #28200:
URL: https://github.com/apache/spark/pull/28200#discussion_r413724254
##########
File path: pom.xml
##########
@@ -928,6 +928,18 @@
<version>0.11</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stefanbirkner</groupId>
Review comment:
System#getProperties and System#getenv are slightly different. Since I
use the environment variable, we can't use the suggested way(I choose
System#getenv because SPARK_CONF_DIR also uses environment variable).
https://docs.oracle.com/javase/8/docs/api/java/lang/System.html#getProperties--
https://docs.oracle.com/javase/8/docs/api/java/lang/System.html#getenv--
If adding new dependencies in this PR is unacceptable, I will open another
PR aimed at improving test coverage using environment variables.
It seems that some code that uses environment variables is not
branch-covered according to a coverage report I created. While improving branch
coverage of existing stable code may not be very useful, I don't think it is
harmful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
