peter-toth commented on a change in pull request #28318:
URL: https://github.com/apache/spark/pull/28318#discussion_r414045255
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala
##########
@@ -131,37 +121,27 @@ object CTESubstitution extends Rule[LogicalPlan] {
* SELECT * FROM t
* )
* @param plan the plan to be traversed
- * @param inTraverse whether the current traverse is called from another
traverse, only in this
- * case name collision can occur
* @return the plan where CTE substitution is applied
*/
- private def traverseAndSubstituteCTE(plan: LogicalPlan, inTraverse:
Boolean): LogicalPlan = {
+ private def traverseAndSubstituteCTE(plan: LogicalPlan): LogicalPlan = {
plan.resolveOperatorsUp {
case With(child: LogicalPlan, relations) =>
- // child might contain an inner CTE that has priority so traverse and
substitute inner CTEs
Review comment:
This was an incorrect assumption that only direct child can contain a
nested, conflicting CTE as subquery expression. As the added new test case
shows such a conflicting CTE can be in any node under `With`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
