Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5005#issuecomment-79156112
@debasish83 Let's first implement breeze-based solvers as new solvers
instead of replacing old ones. So we can easily compare the performance and
accuracy. For example, you are using `quardMinimizer.updateGram` to assemble
the normal equation. But this go into several functions calls, which is not as
fast as the implementation in master. And it updates the full matrix instead of
the upper triangular one. So we need to profile there solvers. Could you do a
micro-benchmark and share some results? This also applies to the nonnegative
solver in breeze.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
