HyukjinKwon commented on pull request #28307: URL: https://github.com/apache/spark/pull/28307#issuecomment-618756040
TL;DR: I don't think this is a big problem. I investigated on a topic related to this incident for a while before actually so I guess I have some more things to say here :-). As far as I know Apache Parquet and some other Apache projects moved to Github Merge feature instead of the manual merging by the merger script. Practically it sounds better to me because we can now do many things such as closing PRs manually ever since we moved our repo. I was investigating to propose to use Github Merge feature in Apache Spark too. However, Github team introduced a behaviour change on the commit credit, well, silently and suddenly - about the merger and author in the commit log. The issue is open here https://github.com/isaacs/github/issues/1303, and I gave them my feedback on this. It might be interesting to read the discussion there. As of now, the merger is not included, which I personally don't think it's ideal into Apache Spark at least. So, I stopped working on this for now. I also discussed this with Github team offline, and seems they are working on a feature to run a script via a command such as `@github merge` as an alternative. Once they introduce such feature, we could discuss about migrating to that feature. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
