cloud-fan commented on pull request #28269: URL: https://github.com/apache/spark/pull/28269#issuecomment-618829322
I start to think if we should merge `In` and `InSet`. It's awkward to have an expression which is just an optimized version of another expression and doesn't have its own semantic. Every time we want to match an IN operator, we need to match both `In` and `InSet`. And if we want to create an IN operator after the optimization phase, we need to redo the `In` to `InSet` conversion. cc @rxin @hvanhovell @viirya ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
