maropu commented on a change in pull request #28322:
URL: https://github.com/apache/spark/pull/28322#discussion_r415009944
##########
File path: sql/gen-sql-config-docs.py
##########
@@ -119,17 +119,13 @@ def generate_sql_configs_table_html(sql_configs, path):
if __name__ == "__main__":
- if len(sys.argv) != 2:
- print("Usage: ./bin/spark-submit sql/gen-sql-config-docs.py
<static|runtime>")
- sys.exit(-1)
- else:
- group = sys.argv[1]
-
Review comment:
Plz describe why we need this update in the PR description? Probably,
this is a followup of the Hyukjin comment ?
https://github.com/apache/spark/pull/28274#discussion_r412893096
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
