sarutak commented on a change in pull request #28333:
URL: https://github.com/apache/spark/pull/28333#discussion_r415076102
##########
File path:
sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/spark-sql-viz.js
##########
@@ -210,8 +208,8 @@ function postprocessForAdditionalMetrics() {
checkboxNode.click(function() {
onClickAdditionalMetricsCheckbox($(this));
});
- var isChecked = window.localStorage.getItem("stageId-and-taskId-checked") ==
"true";
- $("#stageId-and-taskId-checkbox").prop("checked", isChecked);
+ var isChecked = window.localStorage.getItem("stageId-and-taskId-checked")
=== "true";
+ checkboxNode.prop("checked", isChecked);
Review comment:
I think it's not a bug but improvement to avoid
`$("#stageId-and-taskId-checkboc")` twice.
This is introduced by #28039 and merged into `master` and `branch-3.0` so I
think it's better to backport this change into `branch-3.0`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
