MaxGekk commented on a change in pull request #28345:
URL: https://github.com/apache/spark/pull/28345#discussion_r415134124
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##########
@@ -67,7 +67,8 @@ trait LegacyDateFormatter extends DateFormatter {
override def parse(s: String): Int = {
val micros = DateTimeUtils.millisToMicros(parseToDate(s).getTime)
- DateTimeUtils.microsToDays(micros)
+ val julianDays = DateTimeUtils.microsToDays(micros)
Review comment:
I think need to rebase micros instead of days because `microsToDays()`
is based on Proleptic Gregorian calendar already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
