cloud-fan commented on a change in pull request #28109:
URL: https://github.com/apache/spark/pull/28109#discussion_r415519482
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CustomShuffleReaderExec.scala
##########
@@ -153,7 +170,9 @@ case class CustomShuffleReaderExec private(
} ++ {
if (hasSkewedPartition) {
Map("numSkewedPartitions" ->
- SQLMetrics.createMetric(sparkContext, "number of skewed
partitions"))
+ SQLMetrics.createMetric(sparkContext, "number of skewed
partitions"),
+ "numSkewedSplits" ->
+ SQLMetrics.createNumMetric(sparkContext, "number of skewed
partition splits"))
Review comment:
We just set the value once. This can be simply `createMetric`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
