MichaelChirico commented on a change in pull request #28365:
URL: https://github.com/apache/spark/pull/28365#discussion_r415683919
##########
File path: R/pkg/R/install.R
##########
@@ -293,7 +289,7 @@ sparkCachePath <- function() {
Sys.getenv("XDG_CACHE_HOME", file.path(Sys.getenv("HOME"), ".cache")),
"spark")
}
} else {
- stop(sprintf("Unknown OS: %s", .Platform$OS.type))
+ stop(gettextf("Unknown OS: %s", .Platform$OS.type, domain = "R-SparkR"),
domain = NA)
Review comment:
See Diagnostic Messages from [Writing R
Extensions](https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Diagnostic-messages):
> Try not to split up messages into small pieces. In C error messages use a
single format string containing all English words in the messages.
> In R error messages do not construct a message with `paste` (such messages
will not be translated) but via multiple arguments to `stop` or `warning`, or
via `gettextf`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
