xuanyuanking commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620013841
Change the approach to delete the metadata propagating logic in Column in 05ed338. At first, I just followed the `name` API meaning and do the fix in analyzer rule. But after discussing with @cloud-fan and checking the #8215, which introduces the changes for `Column.as`, revert the propagating here should be the right way. For watermark metadata here, we need to keep it in top-level alias. Since the `TimeWindow` will be resolved in `TimeWindowingRule` and then the metadata take effect, the existing logic in `Alias.metadata` already ensure the propagation of metadata. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
