Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4733#discussion_r26439546
  
    --- Diff: project/MimaExcludes.scala ---
    @@ -181,6 +181,9 @@ object MimaExcludes {
                 
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.RealClock"),
                 
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.Clock"),
                 
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.TestClock")
    +          ) ++ Seq(
    --- End diff --
    
    OK, right, this is what @ankurdave was saying was an acceptable API change 
since this isn't meant to be extended anyway and can't technically be extended 
because a class the API uses isn't public. I'd still rather let him or 
@jegonzal push the final button as it's touching the API of GraphX.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to