MaxGekk edited a comment on pull request #28369: URL: https://github.com/apache/spark/pull/28369#issuecomment-620107619
> Can you explain the reason why it should follow that specific case but not other common ones？ because 1. You do benchmarking of particular functions, and it doesn't matter from where they are called - from generated code or not 2. Wholestage on is common, and default case 3. As your benchmark result show there are no diffs between wholestage on/off 4. And it is easier to analyze benchmark results when everything related in one table ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
