HeartSaVioR commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-620272637
Just FYI, looks like the merged commit doesn't reflect the credit properly (not showing as 2 authors) - maybe because of the authorship of the first commit. author and committer were swapped. Maybe ideal to ask about @LiangchangZ whether it's OK. Btw, I'd like to be sure about how to address the follow up PR across all branches, as it leaves up two tasks, backport PR for branch-2.4, follow up PR for master. Ideally we'd be better to sync up the commit, hence making backport PR don't contain the follow-up, and follow-up PR to be ported back as well. (Ideally it'd be nice to wait for couple of days more to address all of valid comments to avoid such situation.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
