holdenk commented on a change in pull request #28373:
URL: https://github.com/apache/spark/pull/28373#discussion_r416215339
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
##########
@@ -320,4 +320,11 @@ class HiveOrcSourceSuite extends OrcSuite with
TestHiveSingleton {
}
}
}
+
+ test("SPARK-31580: Read a file written before ORC-569") {
+ assume(HiveUtils.isHive23) // Hive 1.2 doesn't use Apache ORC
Review comment:
I haven't seen this before, that's a cool feature :)
That being said I'm not sure about the version number check here, looking at
the related JIRAs https://issues.apache.org/jira/browse/HIVE-22480 &
https://issues.apache.org/jira/browse/ORC-569 it seems like it should be fixed
earlier? Or is that JIRA wrong?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
