dongjoon-hyun commented on a change in pull request #27803:
URL: https://github.com/apache/spark/pull/27803#discussion_r416333033



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -2203,13 +2220,41 @@ class Analyzer(
       }.nonEmpty)
     }
 
-    private def trimAlias(expr: NamedExpression): Expression = expr match {
+    private def trimAlias(expr: Expression): Expression = expr match {
       case UnresolvedAlias(child, _) => child
       case Alias(child, _) => child
       case MultiAlias(child, _) => child
       case _ => expr
     }
 
+    private def createGenerate(
+        generator: Generator,
+        outer: Boolean,
+        names: Seq[String],
+        child: LogicalPlan): Generate = {
+      Generate(
+        generator,
+        unrequiredChildIndex = Nil,
+        outer = outer,
+        qualifier = None,
+        generatorOutput = ResolveGenerate.makeGeneratorOutput(generator, 
names),
+        child)
+    }
+
+    private def collectAdjacentGenerators(children: Seq[Expression]): 
Seq[(Generator, Boolean)] = {

Review comment:
       Could you describe the output as a function description, please? For 
example, the purpose of the second boolean in the result pair?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to