dongjoon-hyun commented on a change in pull request #28392:
URL: https://github.com/apache/spark/pull/28392#discussion_r416809229
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala
##########
@@ -145,6 +156,11 @@ case class Randn(child: Expression) extends RDG with
ExpressionWithRandomSeed {
}
override def freshCopy(): Randn = Randn(child)
+
+ override def flatArguments: Iterator[Any] = Iterator(child)
+ override def sql: String = {
+ s"randn(${if (useRandSeed) "" else child.sql})"
Review comment:
The naming `useRandSeed` might be a little mismatched. This is used only
here to hide random seed. Maybe, something like `hideSeed` is more direct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
