sririshindra commented on a change in pull request #28330:
URL: https://github.com/apache/spark/pull/28330#discussion_r416809429
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
##########
@@ -325,34 +325,57 @@ class SQLMetricsSuite extends SharedSparkSession with
SQLMetricsTestUtils
// +- LocalTableScan(nodeId = 7)
Seq((1L, 2L, 5L, false), (2L, 3L, 7L, true)).foreach {
case (nodeId1, nodeId2, nodeId3, enableWholeStage) =>
- val df = df1.join(df2, "key")
- testSparkPlanMetrics(df, 1, Map(
- nodeId1 -> (("ShuffledHashJoin", Map(
- "number of output rows" -> 2L))),
- nodeId2 -> (("Exchange", Map(
- "shuffle records written" -> 2L,
- "records read" -> 2L))),
- nodeId3 -> (("Exchange", Map(
- "shuffle records written" -> 10L,
- "records read" -> 10L)))),
- enableWholeStage
- )
+ val df = df1.join(df2, "key")
+ testSparkPlanMetrics(df, 1, Map(
+ nodeId1 -> (("ShuffledHashJoin", Map(
+ "number of output rows" -> 2L))),
+ nodeId2 -> (("Exchange", Map(
+ "shuffle records written" -> 2L,
+ "records read" -> 2L))),
+ nodeId3 -> (("Exchange", Map(
+ "shuffle records written" -> 10L,
+ "records read" -> 10L)))),
+ enableWholeStage
Review comment:
I think this indentation is correct. I know it is just a small cosmetic
change and probably doesn't need to be included in this PR. I will remove it if
you think this should not be there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
