maropu commented on a change in pull request #28194:
URL: https://github.com/apache/spark/pull/28194#discussion_r416999108



##########
File path: sql/core/src/test/resources/sql-functions/sql-expression-schema.md
##########
@@ -0,0 +1,337 @@
+## Summary

Review comment:
       How about making the file name more clear for a golden file? For 
example, `sql-functions/sql-expression-schema.md` -> 
`sql-functions/sql-expression-schema-golden.md`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to