dongjoon-hyun commented on a change in pull request #28392:
URL: https://github.com/apache/spark/pull/28392#discussion_r417070637
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -3425,6 +3425,28 @@ class SQLQuerySuite extends QueryTest with
SharedSparkSession with AdaptiveSpark
assert(SQLConf.get.getConf(SQLConf.CODEGEN_FALLBACK) === true)
}
}
+
+ test("SPARK-31594: Do not display the seed of rand/randn with no argument in
output schema") {
+ def checkIfSeedExistsInExplain(df: DataFrame): Unit = {
+ val output = new java.io.ByteArrayOutputStream()
+ Console.withOut(output) {
+ df.explain()
+ }
+ output.toString.matches("""randn?\(-?[0-9]+\)""")
+ }
+ val df1 = sql("SELECT rand()")
+ assert(df1.schema.head.name === "rand()")
+ checkIfSeedExistsInExplain(df1)
Review comment:
If we add `assert` at line 3435, this test will fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
