srowen commented on a change in pull request #28365:
URL: https://github.com/apache/spark/pull/28365#discussion_r417353910
##########
File path: R/pkg/tests/fulltests/test_sparkSQL.R
##########
@@ -2558,7 +2558,7 @@ test_that("join(), crossJoin() and merge() on a
DataFrame", {
error_msg <- paste("joinType must be one of the following types:",
"'inner', 'cross', 'outer', 'full', 'fullouter',
'full_outer',",
"'left', 'leftouter', 'left_outer', 'right', 'rightouter',
'right_outer',",
- "'semi', 'leftsemi', 'left_semi', 'anti', 'leftanti' or
'left_anti'.")
+ "'semi', 'left_semi', 'leftsemi', 'anti', 'left_anti',
'leftanti'")
Review comment:
You can also 'fix' the order of the list in the original code to be
consistent with the test instead. It's really minor but the order in the test
looks more consistent: leftfoo, left_foo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
