attilapiros commented on a change in pull request #28094:
URL: https://github.com/apache/spark/pull/28094#discussion_r417425365



##########
File path: core/src/main/scala/org/apache/spark/status/LiveEntity.scala
##########
@@ -245,6 +245,21 @@ private class LiveTask(
 
 }
 
+private class LiveResourceProfile(val resourceProfileId: Int) extends 
LiveEntity {
+
+  var executorResources = Map[String, ExecutorResourceRequest]()
+  var taskResources = Map[String, TaskResourceRequest]()
+  var maxTasksPerExecutor: Option[Int] = None

Review comment:
       We can make `vals` and  constructor parameters from these three:
   ```scala
    private class LiveResourceProfile(val resourceProfileId: Int,
        val executorResources: Map[String, ExecutorResourceRequest] = Map(),
        val taskResources: Map[String, TaskResourceRequest] = Map(),
        val maxTasksPerExecutor: Option[Int] = None) extends LiveEntity {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to