attilapiros commented on pull request #28094: URL: https://github.com/apache/spark/pull/28094#issuecomment-621359348
I finished the first round. In addition to the shared review comments I miss a unit test from the `JsonProtocolSuite` where the new `SparkListenerResourceProfileAdded` is tested or at least one call of `testEvent(...)` with the new class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
