maropu commented on a change in pull request #28402:
URL: https://github.com/apache/spark/pull/28402#discussion_r417658197
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/StreamingJoinHelper.scala
##########
@@ -232,6 +232,7 @@ object StreamingJoinHelper extends PredicateHelper with
Logging {
collect(left, negate) ++ collect(right, !negate)
case TimeAdd(left, right, _) =>
collect(left, negate) ++ collect(right, negate)
+ case DatetimeSub(_, _, child) => collect(child, negate)
Review comment:
Just to check; did the change in Analyzer
(https://github.com/apache/spark/pull/28402/files#diff-57b3d87be744b7d79a9beacf8e5e5eb2R310-R313)
invoke some test failures in streaming joins?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
