zhengruifeng commented on a change in pull request #28349: URL: https://github.com/apache/spark/pull/28349#discussion_r417808922
########## File path: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala ########## @@ -154,31 +156,56 @@ class LinearSVC @Since("2.2.0") ( def setAggregationDepth(value: Int): this.type = set(aggregationDepth, value) setDefault(aggregationDepth -> 2) + /** + * Set block size for stacking input data in matrices. Review comment: The choice of size needs tuning, it depends on dataset sparsity and numFeatures, Increasing it may not always increases performance. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org