Github user kellyzly commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4491#discussion_r26463740
  
    --- Diff: 
core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala ---
    @@ -123,12 +133,30 @@ private[spark] class DiskBlockObjectWriter(
        */
       private var numRecordsWritten = 0
     
    +  private var sparkConf:SparkConf = null
    +
       override def open(): BlockObjectWriter = {
         if (hasBeenClosed) {
           throw new IllegalStateException("Writer already closed. Cannot be 
reopened.")
         }
         fos = new FileOutputStream(file, true)
    -    ts = new TimeTrackingOutputStream(fos)
    +    val isEncryptedShuffle = 
sparkConf.getBoolean("spark.encrypted.shuffle", false)
    --- End diff --
    
    @CodingCat , thanks for your comment. I have modified 
https://github.com/kellyzly/spark/blob/master/core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala#L143
 as following:
    ```
       val isEncryptedShuffle: Boolean = if (sparkConf != null)
          sparkConf.getBoolean("spark.encrypted" +
            ".shuffle",
            false)
        else
          false
    ```
    Later will submit the code, do you think it can solve the problem you 
pointed out?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to