dongjoon-hyun commented on a change in pull request #28426:
URL: https://github.com/apache/spark/pull/28426#discussion_r418351194
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -521,14 +521,14 @@ package object config {
.checkValue(_ >= 0L, "Timeout must be >= 0.")
.createWithDefault(60)
- private[spark] val DYN_ALLOCATION_SHUFFLE_TRACKING =
+ private[spark] val DYN_ALLOCATION_SHUFFLE_TRACKING_ENABLED =
ConfigBuilder("spark.dynamicAllocation.shuffleTracking.enabled")
.version("3.0.0")
.booleanConf
.createWithDefault(false)
- private[spark] val DYN_ALLOCATION_SHUFFLE_TIMEOUT =
- ConfigBuilder("spark.dynamicAllocation.shuffleTimeout")
+ private[spark] val DYN_ALLOCATION_SHUFFLE_TRACKING_TIMEOUT =
+ ConfigBuilder("spark.dynamicAllocation.shuffleTracking.timeout")
Review comment:
I agree this name-spacing into `.shuffleTracking`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]