HyukjinKwon commented on a change in pull request #28365:
URL: https://github.com/apache/spark/pull/28365#discussion_r418410881
##########
File path: R/pkg/R/utils.R
##########
@@ -354,8 +354,8 @@ varargsToStrEnv <- function(...) {
} else {
value <- pairs[[name]]
if (!(is.logical(value) || is.numeric(value) || is.character(value) ||
is.null(value))) {
- stop(paste0("Unsupported type for ", name, " : ", class(value),
- ". Supported types are logical, numeric, character and NULL."),
call. = FALSE)
+ stop("Unsupported type for ", name, " : ", toString(class(value)),
". ",
Review comment:
Quick question, why do we need to do `toString`? Were there any
differences at `stop(paste(..., ...))` vs `stop(..., ...)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
