maropu commented on a change in pull request #28425:
URL: https://github.com/apache/spark/pull/28425#discussion_r418410438
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScan.scala
##########
@@ -29,11 +29,13 @@ import
org.apache.spark.sql.catalyst.expressions.codegen.GenerateUnsafeProjectio
import org.apache.spark.sql.connector.read.{Batch, InputPartition, Scan,
Statistics, SupportsReportStatistics}
import org.apache.spark.sql.execution.PartitionedFileUtil
import org.apache.spark.sql.execution.datasources._
+import org.apache.spark.sql.internal.connector.SupportsMetadata
import org.apache.spark.sql.sources.Filter
import org.apache.spark.sql.types.StructType
import org.apache.spark.util.Utils
-trait FileScan extends Scan with Batch with SupportsReportStatistics with
Logging {
+trait FileScan extends Scan
+ with Batch with SupportsReportStatistics with Logging with SupportsMetadata {
Review comment:
super nit: better to put `Logging` in the end? `with Batch with
SupportsReportStatistics with SupportsMetadata with Logging {`. I personally
think we'd better group them by similar features.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
