yaooqinn commented on a change in pull request #28420:
URL: https://github.com/apache/spark/pull/28420#discussion_r418418394
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
##########
@@ -323,6 +323,20 @@ trait RuntimeReplaceable extends UnaryExpression with
Unevaluable {
// two `RuntimeReplaceable` are considered to be semantically equal if their
"child" expressions
// are semantically equal.
override lazy val canonicalized: Expression = child.canonicalized
+
+ override def innerChildren: Seq[Expression] = sys.error("RuntimeReplaceable
must implement" +
+ " innerChildren with the original parameters")
+
+ protected val sqlStrSeparator: String = ", "
+
+ override def sql: String = RuntimeReplaceable.this.prettyName +
+ prettyChildren.map(_.sql).mkString("(", sqlStrSeparator, ")")
+
+ protected var prettyChildren: Seq[Expression] = innerChildren
Review comment:
The `newInstance` seems not robust to make a clone with `Seq[Expression]`
I think we can just add `def prettySQL: String` in RuntimeReplaceable for
`utils.package` to call, and override it wherever needed without creating new
instances.
Seems a better and simpler idea that comes up based on your suggestions,
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
