maropu commented on a change in pull request #28351:
URL: https://github.com/apache/spark/pull/28351#discussion_r418478753
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/collect.scala
##########
@@ -139,6 +148,31 @@ case class CollectSet(
def this(child: Expression) = this(child, 0, 0)
+ override lazy val bufferElementType = child.dataType match {
+ case BinaryType => ArrayType(ByteType)
+ case other => other
+ }
+
+ override def convertToBufferElement(value: Any): Any = child.dataType match {
+ /*
+ * SPARK-31500
+ * collect_set() of BinaryType should not return duplicate elements,
+ * Java byte arrays use referential equality and identity hash codes
+ * so we need to use a different Scala object
Review comment:
nit: `a different Scala object` -> `a catalyst value for arrays`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
