yaooqinn commented on a change in pull request #28420: URL: https://github.com/apache/spark/pull/28420#discussion_r418520909
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala ########## @@ -142,7 +142,10 @@ package object util extends Logging { "`" + name.replace("`", "``") + "`" } - def toPrettySQL(e: Expression): String = usePrettyExpression(e).sql + def toPrettySQL(e: Expression): String = e match { + case r: RuntimeReplaceable => r.prettySQL Review comment: https://github.com/apache/spark/pull/28420/commits/c42a28360abb3265ae1d0e75b81423120e6a2909#diff-6f4edc80e2cc973e748705e85a6053b4R786-R807 fixed and added some nested tests, thanks, good catch! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org