imback82 opened a new pull request #28435:
URL: https://github.com/apache/spark/pull/28435
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Currently, an application is unregistered from YARN resource manager as a
shutdown hook. In the scenario where the shutdown hook does not run (e.g.,
timeouts, etc.), the application is not unregistered, resulting in YARN
resubmitting the application even if it succeeded.
For example, you could see the following on the driver log:
```
20/04/30 06:20:29 INFO SparkContext: Successfully stopped SparkContext
20/04/30 06:20:29 INFO ApplicationMaster: Final app status: SUCCEEDED,
exitCode: 0
20/04/30 06:20:59 WARN ShutdownHookManager: ShutdownHook '$anon$2' timeout,
java.util.concurrent.TimeoutException
java.util.concurrent.TimeoutException
at java.util.concurrent.FutureTask.get(FutureTask.java:205)
at
org.apache.hadoop.util.ShutdownHookManager.executeShutdown(ShutdownHookManager.java:124)
at
org.apache.hadoop.util.ShutdownHookManager$1.run(ShutdownHookManager.java:95)
```
You can see that the final app status is `SUCCEEDED`. However, on the YARN
RM side:
```
020-04-30 06:21:25,083 INFO RMContainerImpl:
container_1588227360159_0001_01_000001 Container Transitioned from RUNNING to
COMPLETED
2020-04-30 06:21:25,085 INFO RMAppAttemptImpl: Updating application attempt
appattempt_1588227360159_0001_000001 with final state: FAILED, and exit status: 0
2020-04-30 06:21:25,085 INFO RMAppAttemptImpl:
appattempt_1588227360159_0001_000001 State change from RUNNING to FINAL_SAVING
on event = CONTAINER_FINISHED
```
You see that the final state of the application becomes `FAILED` since the
container is finished before the application is unregistered.
This could be misleading and this PR proposes to unregister the application
right away if it succeeds.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To fix a bug where application is not unregistered even if it succeeds.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. If the application succeeds, it will be unregistered even if the
shutdown hook doesn't get run.
The following is YARN RM log when there was a timeout on the shutdown hook
after the fix:
```
2020-05-02 02:13:02,222 INFO RMContainerImpl:
container_1588385278256_0001_01_000001 Container Transitioned from RUNNING to
COMPLETED
2020-05-02 02:13:02,222 INFO ApplicationMasterService: Unregistering app
attempt : appattempt_1588385278256_0001_000001
2020-05-02 02:13:02,224 INFO RMAppAttemptImpl:
appattempt_1588385278256_0001_000001 State change from FINISHING to FINISHED on
event = CONTAINER_FINISHED
2020-05-02 02:13:02,226 INFO RMAppImpl: application_1588385278256_0001 State
change from FINISHING to FINISHED on event = ATTEMPT_FINISHED
```
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
Since this behavior is checking against the scenario where shutdown hook is
involved, no test has been added, but manually validated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
