WeichenXu123 commented on a change in pull request #28413:
URL: https://github.com/apache/spark/pull/28413#discussion_r418929103
##########
File path: mllib/src/main/scala/org/apache/spark/ml/feature/HashingTF.scala
##########
@@ -42,14 +42,17 @@ import org.apache.spark.util.VersionUtils.majorMinorVersion
* otherwise the features will not be mapped evenly to the columns.
*/
@Since("1.2.0")
-class HashingTF @Since("1.4.0") (@Since("1.4.0") override val uid: String)
+class HashingTF @Since("3.0.0") (
+ @Since("1.4.0") override val uid: String,
+ private[ml] val hashFunc: Any => Int)
Review comment:
* I preserve old constructor so mima pass.
* Put it in constructor can make it immutable. Otherwise we have to make it
a `var` variable.
> do you want to instead expose a setter that takes some symbolic
representation ?
I will update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
